-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Adding Cluster HoverData #7297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cluster HoverData #7297
Conversation
Thanks very much for the PR.
Please add draftlogs/7297_fix.md for this PR as described here.
Please add a jasmine test in test/jasmine/tests/map_test.js for this feature as well.
Wondering if this fix may also be applied to mapbox?
I believe that this can be applied to mapbox as well. From my understanding, it seems that map is an offshoot of mapbox.
I believe that this can be applied to
mapboxas well. From my understanding, it seems thatmapis an offshoot ofmapbox.
That's true.
Although the mapbox traces would be removed in plotly.js v4, having this change for mapbox would be nice IMHO. cc: @gvwilson @ndrezn
BTW Let's start by adding the tests to map first.
Thank you @BSd3v
Update: There is no need to add this feature to mapbox which is deprecated.
@BSd3v Would you please fetch upstream master and merge it to this branch.
Then please add a jasmine test to test the hover.
Thank you.
Adding hover and click data to clusters for maps.
It currently only emits the plotly_hover and plotly_click events, instead of providing the hoverData directly on screen, automatically.
Looking for feedback and assistance with how to get the
hoverDatato show.@alexcjohnson