You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+2-3Lines changed: 2 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,19 +2,18 @@ Thanks for your interest in plotly.js!
2
2
3
3
### Translations:
4
4
5
-
- Make a PR directly to the main repository
6
5
- Please @ mention a few other speakers of this language who can help review your translations.
7
6
- If you've omitted any keys from [dist/translation_keys.txt](https://github.com/plotly/plotly.js/blob/master/dist/translation-keys.txt) - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
8
7
- You should only update files in `lib/locales/`, not those in `dist/`
9
8
10
9
### Features, Bug fixes, and others:
11
-
Before opening a pull request, developer should:
10
+
11
+
Before opening a pull request, developer should:
12
12
13
13
-`git rebase` their local branch off the latest `master`,
14
14
- make sure to **not**`git add` the `dist/` folder (the `dist/` is updated only on version bumps),
15
15
- make sure to commit changes to the `package-lock.json` file (if any new dependency required),
16
16
- write an overview of what the PR attempts to do,
17
-
- make a PR directly from their fork to the main repository i.e. plotly/plotly.js
18
17
- select the _Allow edits from maintainers_ option (see this [article](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for more details).
19
18
20
19
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please `git merge master` into your PR branch instead of `git rebase master`.
0 commit comments