You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+2-4Lines changed: 2 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,15 +8,13 @@ Thanks for your interest in plotly.js!
8
8
- You should only update files in `lib/locales/`, not those in `dist/`
9
9
10
10
### Features, Bug fixes, and others:
11
-
12
-
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
13
-
14
11
Before opening a pull request, developer should:
15
12
16
13
-`git rebase` their local branch off the latest `master`,
17
14
- make sure to **not**`git add` the `dist/` folder (the `dist/` is updated only on version bumps),
18
-
- make sure to commit changes to the `package-lock.json` file (if any),
15
+
- make sure to commit changes to the `package-lock.json` file (if any new dependency required),
19
16
- write an overview of what the PR attempts to do,
17
+
- make a PR directly from their fork to the main repository i.e. plotly/plotly.js
20
18
- select the _Allow edits from maintainers_ option (see this [article](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for more details).
21
19
22
20
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please `git merge master` into your PR branch instead of `git rebase master`.
0 commit comments