-
Notifications
You must be signed in to change notification settings - Fork 632
Avoid hoveron warning #2302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Avoid hoveron warning #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zeehio
zeehio
force-pushed
the
fix-webgl-hoveron-warning
branch
from
October 8, 2023 03:26
d9652a6 to
65c643f
Compare
@zeehio
zeehio
changed the title
(削除) WIP: Avoid hoveron warning (削除ここまで)
(追記) Avoid hoveron warning (追記ここまで)
Oct 8, 2023
@zeehio
zeehio
force-pushed
the
fix-webgl-hoveron-warning
branch
from
October 19, 2023 04:29
65c643f to
a40ea22
Compare
When converting a ggplot object to webgl, invalid 'hoveron' warnings appear. If the toWebGL() function receives the ggplot object then it is possible for us to remove those warnings. Closes: plotly#2296 Closes: plotly#1582
@zeehio
zeehio
force-pushed
the
fix-webgl-hoveron-warning
branch
from
October 23, 2023 02:51
a40ea22 to
752aa20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a ggplot object to webgl, invalid 'hoveron' warnings appear.
If the toWebGL() function receives the ggplot object then it is possible for us to remove those warnings.
Closes: #2296
Closes: #1582