Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes/workaround for upcoming (> v3.4.3) ggplot2 release #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 12 commits into master from dev-ggplot2-fixes
Oct 11, 2023

Conversation

Copy link
Collaborator

@cpsievert cpsievert commented Oct 6, 2023
edited
Loading

This is just a draft for now -- starting a PR to get visual testing results back

TODO

  • Double-check these fixes work well with CRAN version of ggplot2

Copy link
Collaborator Author

The one remaining failure is due to the fact that the dev version of ggplot2 breaks GGally. I'm just going to ignore that for now since it seems ggplot2 should be fixing that on their end before a release

@cpsievert cpsievert marked this pull request as ready for review October 10, 2023 21:26
@cpsievert cpsievert merged commit 22d715d into master Oct 11, 2023
@cpsievert cpsievert deleted the dev-ggplot2-fixes branch October 11, 2023 00:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpsievert, it seems to me you are hitting jeroen/jsonlite#420 here, that was fixed on jsonlite 1.8.7. Maybe you want to update your jsonlite locally 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zeehio zeehio zeehio left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /