Search code, repositories, users, issues, pull requests...


 Closes  plotly#2016 . Added support for geom_candlestick .

9fb273d


 Added test to showcase the functionality.

35b95a8


 Added test to showcase the functionality.

e18b3fc

@moutikabdessabour moutikabdessabour requested a review from cpsievert

October 23, 2021 07:23

moutikabdessabour added 2 commits

October 23, 2021 00:23


 Added test to showcase the functionality.

46203d5


 Modified the step test as the new feauture kinda broke the tests

68466fc

cpsievert

cpsievert reviewed

NEWS.md Outdated Show resolved Hide resolved

cpsievert

cpsievert reviewed

tests/testthat/test-geom-candlestick.R Outdated Show resolved Hide resolved

cpsievert

cpsievert reviewed

tests/testthat/test-geom-candlestick.R

@@ -0,0 +1,37 @@

if(require(tidyquant)){

Copy link

Collaborator

@cpsievert cpsievert Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use testthat::skip_if_not_installed() instead

cpsievert

cpsievert reviewed

R/layers2traces.R

Comment on lines +625 to +633

#' @export

to_basic.GeomRectCS <- function(data, ...){

to_basic.GeomRect(data, ...)

}

#' @export

to_basic.GeomLinerangeBC <- function(data, ...){

data[, c("xend", "y", "yend")] <- data[, c("x", "ymin", "ymax")]

to_basic.GeomSegment(data, ...)

}

Copy link

Collaborator

@cpsievert cpsievert Nov 1, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do more to come up with better hovertext (the tooltip info is basically useless at this point).

Copy link

Contributor Author

@moutikabdessabour moutikabdessabour Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this

cpsievert

cpsievert requested changes

Nov 2, 2021