Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

quick implementation of most of ggraph/ggforce #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpsievert wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from ggexts
Open

Conversation

Copy link
Collaborator

@cpsievert cpsievert commented Aug 22, 2018
edited
Loading

TODO:

  • Converters for ggforce's GeomMarkCircle/GeomMarkEllipsis/GeomMarkHull
  • Converter for ggraph's GeomAxisHive (path + text?). For example, see https://github.com/thomasp85/ggraph/blob/8d23845/R/geom_axis_hive.R#L123-L142
  • Add relevant key attributes.
  • Throw warnings/pointers to issues when lack of plotly.js support for color/width arrays is relevant (perhaps this should be done at the geom2trace() level).
  • Catch cases where we need to incorporate geom params into the drawing logic?
  • Tests!

cassandraxmah reacted with thumbs up emoji
Copy link

gvdr commented Jan 23, 2020

Was this PR ever considered? What's the situation now?

Copy link
Collaborator Author

cpsievert commented Nov 2, 2021
edited
Loading

@danton267 would you mind filing an issue requesting this feature? Having some {ggraph}/{ggforce} support would have a much higher ROI compared to some of the other extensions you've requested https://github.com/plotly/plotly.R/issues/created_by/danton267

Copy link
Contributor

@cpsievert I will happily work on some of the geoms

Copy link
Collaborator Author

@moutikabdessabour it'd be great if you could also look into converting {ggraph} based treemaps, so that we can avoid the potential licensing issues with converting {treemapify} #2051

Copy link
Contributor

moutikabdessabour commented Nov 2, 2021
edited
Loading

@cpsievert currently implementing ggraph's GeomAxisHive. Once I will finish I will move forward to ggraph's treemaps

This comment has been minimized.

Copy link
Contributor

moutikabdessabour commented Nov 3, 2021
edited
Loading

I implemented the ggraph's {treemap} this is the one that's similar to {treemapify} output.
Screen Shot 2021年11月03日 at 4 25 20 AM

Do you think I should go forward and implement all the examples found here?? https://www.data-imaginist.com/2017/ggraph-introduction-layouts/

Now all the hierarchical plots are supported.

EDIT:

I just noticed that you had some of the geoms implemented in this PR. so ggraph treemaps are supported in this PR too

EDIT 2:
I managed to get the desired output for ggraph::geom_axis_hive. How can I push the changes? or do you want me to paste the code here.

Screen Shot 2021年11月03日 at 6 25 47 AM

Edit 3:

Managed to implement GeomMarkCircle
Screen Shot 2021年11月03日 at 7 40 07 AM

I was able to implement all the ggforce geoms you put in the first comment.

@cpsievert how would I convert mm to px in plotly? thanks again for your time.

Copy link

Hello @moutikabdessabour @cpsievert ! Thanks for your work - I am new to posting GitHub issues.

Out of the ggforce package, is it possible to implement the geom_GeomPathInterpolate() so that the geom_link2() will plot?
Thank you! And any workarounds appreciated :)

Copy link

Just want to put in my two cents that this would be an incredible addition if it somehow passes checks one day.

alexpghayes reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /