Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[wip] in-ns form#506

Open
thomasmulvaney wants to merge 2 commits into
pixie-lang:master from
thomasmulvaney:in-ns-experiment
Open

[wip] in-ns form #506
thomasmulvaney wants to merge 2 commits into
pixie-lang:master from
thomasmulvaney:in-ns-experiment

Conversation

@thomasmulvaney

@thomasmulvaney thomasmulvaney commented Mar 6, 2016

Copy link
Copy Markdown
Member

This is an attempt to address #366

This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probably to with the deftest macro. For example the defprotocol inside a test broke unless i put a (in-ns ...) before it. Also I had to wrap some code in eval so it would end up in the foo namespace and not in the pixie.test.test-stdlib namespace.

Ideally we shouldn't have to make the changes I made to the tests. Any thoughts?

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /