-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
heyLu
commented
Nov 7, 2015
Can you make the helper functions (trampoline and the -merge fns) private?
You also mentioned in #361 that you had implemented a version using arrays, do you still have that or did it not work out?
thomasmulvaney
commented
Nov 7, 2015
I agree the helpers should be private. Trampoline might be the exception as
it is rather useful. My mutating version got over ambitious when I tried
adding some of the TimSort optimizations - it's rather broken at the moment.
I'll make those adjusts tomorrow evening.
Cheers
On Nov 7, 2015 9:42 AM, "Lucas Stadler" notifications@github.com wrote:
Can you make the helper functions (trampoline and the -merge fns) private?
You also mentioned in #361 that you had implemented a version using
arrays, do you still have that or did it not work out?—
Reply to this email directly or view it on GitHub.
FIxes stackoverflow in JIT mode with a trampoline. We should still look for a C lib that could do this stuff or at least do a dirty mutating approach which is more JIT friendly. For now this is at least a simple solution.