Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix SPM support#588

Open
woxtu wants to merge 4 commits intopinterest:master from
woxtu:patch
Open

Fix SPM support #588
woxtu wants to merge 4 commits intopinterest:master from
woxtu:patch

Conversation

@woxtu
Copy link

@woxtu woxtu commented Nov 19, 2020
edited
Loading

Hi,

The current release installed by SPM can't import headers as follows:

fatal error: 'PINRemoteImage/PINRemoteImage.h' file not found
#import <PINRemoteImage/PINRemoteImage.h>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And categories are not loaded:

error: no visible @interface for 'NSImageView' declares the selector 'pin_setImageFromURL:'
[imageView pin_setImageFromURL:[NSURL URLWithString:@"http://pinterest.com/kitten.jpg"]];
 ~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~

This PR contains the following changes to fix that:

  • Put header files back next to source files
  • Create new public headers directory
  • Add missing imports to the framework header

bpollman reacted with thumbs up emoji
Copy link

grangej commented Dec 1, 2020

This does seem to fix the build but it seems to break the categories.

Copy link
Author

woxtu commented Dec 2, 2020

@grangej
Thank you for your pointing out.
I could confirm that categories is not loaded, and maybe the current release has same issue.
Anyway I'll fix that.

Copy link

grangej commented Dec 12, 2020

Awesome , any chance we can get this merged ??

bpollman reacted with eyes emoji

Copy link

mthole commented Apr 16, 2021

Bump?

Copy link

mthole commented Apr 16, 2021

FYI: This may be taken care of by #586 already, which is merged to master but not in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /