-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix @pierre/diffs import path to resolve Vite build error#3074
Draft
cursor[bot] wants to merge 3 commits into
Draft
Fix @pierre/diffs import path to resolve Vite build error #3074cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
The import was using a non-exported subpath './utils/parsePatchFiles' which caused Vite to fail during development. The parsePatchFiles function is exported from the main '@pierre/diffs' package entry point. Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
@github-actions
github-actions
Bot
added
vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:S
10-29 changed lines (additions + deletions).
labels
Jun 13, 2026
This reverts commit 53be870.
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
@github-actions
github-actions
Bot
added
size:XS
0-9 changed lines (additions + deletions).
and removed
size:S
10-29 changed lines (additions + deletions).
labels
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Problem
The development server was failing to load the
/draft/react-scan-demoroute due to a module resolution error:Solution
Changed the import in
apps/web/src/lib/diffRendering.tsfrom:to:
The
parsePatchFilesfunction is exported from the main package entry point, and the subpath import was not listed in the package's exports field.Testing
Note
Fix
@pierre/diffsimport path indiffRendering.tsto resolve Vite build errorparsePatchFilesimport in diffRendering.ts from@pierre/diffs/utils/parsePatchFilesto@pierre/diffs, fixing a Vite build failure caused by an invalid deep import path.VITE_REACT_SCAN_DEMO === "1", pre-populating a scoped project ref and thread metadata for react-scan demo use.react-scanauto script from a CDN via a script tag in index.html.📊 Macroscope summarized 53be870. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.