-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Improve idiomatic Effect usage in config and Tailscale paths#3073
Draft
cursor[bot] wants to merge 4 commits into
Draft
Improve idiomatic Effect usage in config and Tailscale paths #3073cursor[bot] wants to merge 4 commits into
cursor[bot] wants to merge 4 commits into
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
@github-actions
github-actions
Bot
added
vouch:trusted
PR author is trusted by repo permissions or the VOUCHED list.
size:M
30-99 changed lines (additions + deletions).
labels
Jun 13, 2026
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What Changed
JSON.parse/nullflow with shared Schema lenient JSON decoding andOptionhandling.Durationvalues andDuration.Inputtimeout wiring.readTailscaleStatus.Why
These are small, focused idiomatic Effect improvements that make parsing and timeout behavior easier to test and maintain without escaping to ad-hoc JSON parsing or real-time waits.
UI Changes
N/A - no UI changes.
Checklist
Note
Refactor VCS config parsing and Tailscale timeouts to use idiomatic Effect patterns
VcsProjectConfigwithOption-based control flow; malformed or schema-invalid JSON in.t3code/vcs.jsonnow falls back to'auto'with a warning log instead of propagating errors.Duration-typed values (TAILSCALE_STATUS_TIMEOUT,TAILSCALE_SERVE_TIMEOUT,TAILSCALE_PROBE_TIMEOUT) and updates all call sites.TestClock.probeTailscaleHttpsEndpointcallers must now passtimeout: Duration.Inputinstead oftimeoutMs: number.Macroscope summarized 3152229.