What Changed

• Removed the direct useEffect that mirrored provider environment props into local draft row state in ProviderEnvironmentSection.
• Key the small environment editor from the upstream environment values so external changes still reset the draft editor without a cascading effect render.

Why

React Doctor flagged ProviderInstanceCard.tsx for synchronous state updates inside an effect. This environment editor already owns draft rows locally during edits and publishes committed rows upward, so the mirror effect added an extra render pass after normal commits. Remounting the editor only when upstream environment values change preserves reset behavior while avoiding the unnecessary effect.

UI Changes

Before/after react-scan recordings were captured with react-scan enabled:

• Before: react_scan_provider_env_before.mp4
• After: react_scan_provider_env_after.mp4

React Doctor verification: the post-fix performance scan no longer reports src/components/settings/ProviderInstanceCard.tsx:165 under the synchronous setState-in-effect diagnostic.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Validation:

• react-doctor --verbose --category performance (targeted finding removed; other existing repo findings remain)
• vp check (passed with existing warnings)
• vp run typecheck (passed)