This repository was archived by the owner on Mar 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Add missed features, cleanup #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC-break: removed $extensions argument from V8\Context constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds more missed API to bring ES Modules closer. At this time their API is highly experimental, so it doesn't make much sense to add support for them at this time (unless you want to practice in gdb and catching segfaults), let's wait before getting more stable.
Public API changes In this PR and changes that may affect BC:
*
- BC-breaking or potentially BC-breaking changes*
Raise required V8 version to 5.8.168;*
Remove non-standardV8\Scrip::{getSource,getOrigin}
;*
Drop non-workingV8\Context
extensions support;*
Add$is_wasm
and$is_module
options toV8\ScriptOriginOptions
andV8\ScriptOrigin
;*
HandleV8\IntegerValue
sub-types when returning values from V8, fixes Distinguish number between int and float #19 ;V8\UnboundScript
class;V8\ScriptCompiler\CachedData
class;V8\AccessControl
class;V8\ScriptCompiler\CompileOptions
class;V8\ScriptCompiler\Source
class;V8\ScriptCompiler
;V8\SymbolValue::GetToPrimitive()
method.