-
Notifications
You must be signed in to change notification settings - Fork 96
Add stubs for (some) Symfony iterable types #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stubs/HeaderBag.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong - it has to @implements \IteratorAggregate
stubs/Session.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong - it has to @implements \IteratorAggregate
c8b4dcf to
1f6a244
Compare
Thanks!
Thanks, tested dev-master with deleted stubs in our codebase and works as expected :)
Thank you!
These are types where PHPStan on lvl 6 was complaining about missing iterable information (in our codebase) - there will be probably more, but I think especially the form ones are quite wide spread.
Original types for reference:
As per discussion with @ondrejmirtes I am not adding any dependencies.