-
Notifications
You must be signed in to change notification settings - Fork 96
Alternative way to initialize ConsoleApplicationResolver #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0744c0 to
5952eb3
Compare
5952eb3 to
bc54d84
Compare
@lookyman WDYT?
TBH I don't like it, but I don't know why. 🤷 Let me get a second opinion. @ondrejmirtes Do we want it?
I don't think it's necessary. There's already a way to do it which is straightforward. I'm not even sure how this should work - do Symfony application even extend the Kernel class with their own? I worry that people would shoot themselves in the foot with this one and complain it doesn't work.
I agree that current implementation is more flexable, you can define your application as you mind. But I think a separate file with a console application creation for PHPStan is redundantly. I would to get it simpler, ideally the application from bin/console should be used but I don't know how. :)
I think it’s simple enough without any downside currently.
I propose to add an alternative more simple way to initialize
ConsoleApplicationResolver. The most popular way to create a console application is already described in README - it's just create an application kernel and create a console application with it. And no need to create a file specially for this.