-
Notifications
You must be signed in to change notification settings - Fork 96
Fix issue while loading a container #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the simplexml_load_string
solution better. Also, could you add a test for that? Thanks!
When the URI of the container contains escaped characters like `%2F`, `simplexml_load_file` throw an error.
@jdeniau
jdeniau
force-pushed
the
patch-1
branch
from
March 5, 2019 10:27
8dc8025
to
da1b601
Compare
@lookyman done
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
When the URI of the container contains escaped characters like
%2F
,simplexml_load_file
throw an error.(削除) According to the documentation : (削除ここまで)(削除) I don't understand exactly what should not be done since PHP 5.1.0, but with PHP 7.2, I reproduced the following error : (削除ここまで)Another possible fix is to use: