-
Notifications
You must be signed in to change notification settings - Fork 96
Separate rules from extension as in other phpstan extensions #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree, but README also needs updating and this can be released as 0.12 because it's a BC break.
@mcfedr
mcfedr
force-pushed
the
rules
branch
from
February 26, 2019 09:21
4867807 to
96fcbce
Compare
Added README changes
This needs rebasing because of new rules and conflict in extension.neon
@lookyman
lookyman
force-pushed
the
rules
branch
from
April 27, 2019 16:31
96fcbce to
0439a58
Compare
@lookyman
lookyman
force-pushed
the
rules
branch
from
April 28, 2019 06:49
0439a58 to
f79eb89
Compare
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this because issue of false positives in test cases, #27, but anyway, its the style in all the other phpstan plugins, so would be good to do the same here