-
Notifications
You must be signed in to change notification settings - Fork 95
Add stub for Compound::getConstraints() #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ondrejmirtes
merged 1 commit into
phpstan:1.3.x
from
derrabus:improvement/compound-stub
Apr 12, 2024
Merged
Add stub for Compound::getConstraints() #388
ondrejmirtes
merged 1 commit into
phpstan:1.3.x
from
derrabus:improvement/compound-stub
Apr 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@derrabus
derrabus
force-pushed
the
improvement/compound-stub
branch
from
April 11, 2024 14:50
4c7c696 to
53bfde1
Compare
Thank you! :)
Symfony does not document the structure of the
$optionsarray, which can be an array of anything.
Looking at the usage, I think it should be array<string, mixed> rather than array<mixed>
I created symfony/symfony#54574 to validate the point @derrabus.
Thank you for opening the PR upstream. I've left a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a error people get when implementing compound constraints:
Symfony does not document the structure of the
$optionsarray, which can be an array of anything.