-
Notifications
You must be signed in to change notification settings - Fork 96
Allow service subscriber to have non-service name keys under certain circumstances. #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Basster
wants to merge
4
commits into
phpstan:1.2.x
from
Basster:service-subscriber-private-services
Open
Allow service subscriber to have non-service name keys under certain circumstances. #352
Basster
wants to merge
4
commits into
phpstan:1.2.x
from
Basster:service-subscriber-private-services
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... not the service name.
As is, this won't solve #89. For that, you would have to do the same detection of ServiceSubscriberInterface in the ContainerInterfacePrivateServiceRule.
@ondrejmirtes
ondrejmirtes
force-pushed
the
1.2.x
branch
from
September 28, 2023 12:19
7120655
to
931c6b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
You can define service subscribers with non-service name keys, e.g.
phpstan currently reports this as
Service "upload" is not registered in the container.
This PR allows non-service argument names when the argument is a container and its called within a ServiceLocator.
Maybe, this is also related to #89