Honor new contracts namespace as-of Symfony 4.2 for ServiceSubscriberInterface #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lookyman merged 3 commits into phpstan:master from keichinger:updated-servicesubscriberinterface

Feb 13, 2019

Merged

Honor new contracts namespace as-of Symfony 4.2 for ServiceSubscriberInterface #33

lookyman merged 3 commits into phpstan:master from keichinger:updated-servicesubscriberinterface

Feb 13, 2019

Conversation

keichinger

Copy link

@keichinger keichinger commented Feb 7, 2019

In Symfony 4.2 the ServiceSubscriberInterface has been moved into its own contracts namespace. This commit adds support for the new interface and adds more test-coverage for all possible cases/combinations.

This is a follow-up on #19 (c340de8)

@lookyman lookyman self-assigned this

Feb 7, 2019

@keichinger

Copy link

Author

keichinger commented Feb 7, 2019

@lookyman I might need your help to fix the CI. The tests are passing on my local machine under PHP 7.2. I just have no idea how the CI is dealing with composer's autoloader. The tests shouldn't even execute when the interface is not present 🤷‍♂️

@lookyman

Copy link

Collaborator

lookyman commented Feb 8, 2019

Thanks, I'll have a look at it asap.

Kai Eichinger and others added 3 commits

February 13, 2019 20:27

@lookyman


 Honor new contracts namespace as-of Symfony 4.2 for ServiceSubscriber...

...Interface
In Symfony 4.2 the ServiceSubscriberInterface has been moved into its own contracts namespace. This commit adds support for the new interface and adds more test-coverage for all possible cases/combinations

@lookyman