-
Notifications
You must be signed in to change notification settings - Fork 95
Add stub for options interface #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stub for options interface #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be registered in stubFiles in extension.neon.
Also since you're making Options class generic, you need to add it to parameters.featureToggles.skipCheckGenericClasses, similarly to here: https://github.com/phpstan/phpstan-src/blob/74228e6f930c9a0e6ca9461557a6d40b92cf4e91/conf/config.neon#L23-L33 (this list will be purged with the next major version).
The failures are my bad, with strict-rules these problems are reported: https://phpstan.org/r/2fb146c6-12dc-4a17-bb28-e13d93e820ea
Reported: phpstan/phpstan#7652
Co-authored-by: Richard van Velzen <rvanvelzen1@gmail.com>
c7138a9 to
6559254
Compare
Perfect, thank you!
Uh oh!
There was an error while loading. Please reload this page.
I hope this is correct. First time creating stubs.
Based on discussion in phpstan/phpstan#7650