-
Notifications
You must be signed in to change notification settings - Fork 96
Remove nullable type on InputBag::get() after InputBag::has() call
#250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@franmomu
franmomu
force-pushed
the
input_has
branch
from
February 2, 2022 19:41
77118a5 to
0434ca7
Compare
👍
Thank you!
Hi @franmomu, I'm not sure this DynamicReturnExtension is correct,
The has method is using the array_key_exists check
https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/HttpFoundation/ParameterBag.php#L99
Which means that we can have
$bag->set('foo', null);
$bag->has('foo'); // true
$bag->get('foo'); // null
If so, I'm affraid we'll have to remove this DynamicReturnExtension :(
WDYT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I've used https://github.com/phpstan/phpstan-symfony/blob/df5ce326a8935bf400eb59f7080e568c20ef6246/src/Type/Symfony/RequestTypeSpecifyingExtension.php as example.
Update: maybe we could change it to a
HasGetTypeSpecifyingExtensionand pass theclassNameso it can be reused for other classes as well.