Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add full support for Config/TreeBuilder #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 7 commits into phpstan:master from ruudk:full-tree-builder
Feb 13, 2021

Conversation

Copy link
Contributor

@ruudk ruudk commented Feb 12, 2021
edited
Loading

Fixes #130

It took a bit more work than I expected.

I have tested this on my project and it works fine now.

Copy link
Contributor Author

ruudk commented Feb 12, 2021

@bendavies Could you please validate if it works?

Apply this to your composer.json:

 "repositories": [
 {
 "type": "vcs",
 "url": "http://github.com/ruudk/phpstan-symfony"
 }
 ],
 "require-dev": {
 "phpstan/phpstan-symfony": "dev-full-tree-builder"
 }

and then run composer update phpstan/phpstan-symfony

Copy link

seems to have fixed it yes!

Copy link
Contributor Author

ruudk commented Feb 12, 2021

@ondrejmirtes Applied feedback ✅

Copy link
Contributor Author

ruudk commented Feb 12, 2021

I think it can be done even simpler.... let me give it a shot.

Copy link
Contributor Author

ruudk commented Feb 12, 2021

Tested it on my project again, all good.

@bendavies If you can, please give it another run

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise 👍

Copy link
Member

Alright, let's test this in the wild. I'm gonna tag a release right away.

@ondrejmirtes ondrejmirtes merged commit cc9d9ac into phpstan:master Feb 13, 2021
Copy link
Member

Thank you!

@ruudk ruudk deleted the full-tree-builder branch February 13, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call to an undefined method Symfony\Component\Config\Definition\Builder\NodeParentInterface::scalarNode()

AltStyle によって変換されたページ (->オリジナル) /