-
Notifications
You must be signed in to change notification settings - Fork 96
Add full support for Config/TreeBuilder #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bendavies Could you please validate if it works?
Apply this to your composer.json
:
"repositories": [ { "type": "vcs", "url": "http://github.com/ruudk/phpstan-symfony" } ], "require-dev": { "phpstan/phpstan-symfony": "dev-full-tree-builder" }
and then run composer update phpstan/phpstan-symfony
bendavies
commented
Feb 12, 2021
seems to have fixed it yes!
src/Type/Symfony/Config/NodeDefinitionEndDynamicReturnTypeExtension.php
Outdated
Show resolved
Hide resolved
@ondrejmirtes Applied feedback ✅
I think it can be done even simpler.... let me give it a shot.
Tested it on my project again, all good.
@bendavies If you can, please give it another run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise 👍
Alright, let's test this in the wild. I'm gonna tag a release right away.
Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Fixes #130
It took a bit more work than I expected.
I have tested this on my project and it works fine now.