Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds stub file for PropertyPathInterface #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:master from faizanakram99:master
Jan 25, 2021
Merged

Adds stub file for PropertyPathInterface #124

ondrejmirtes merged 1 commit into phpstan:master from faizanakram99:master
Jan 25, 2021

Conversation

Copy link
Contributor

@faizanakram99 faizanakram99 commented Jan 25, 2021

No description provided.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X and Y were meant to be just placeholders, you should type what it's really iterating over.

Copy link
Contributor Author

faizanakram99 commented Jan 25, 2021
edited
Loading

X and Y were meant to be just placeholders, you should type what it's really iterating over.

yep, forgot to add @template 😅
Fixed

Copy link
Member

This will just cause another error when you typehint the interface. I suppose the iterated types are always the same, check out the implementations what's going on in them.

Copy link
Contributor Author

This will just cause another error when you typehint the interface. I suppose the iterated types are always the same, check out the implementations what's going on in them.

You're right, it showed implementations should be contravariant with parent errors.
From the implementations it looks like key is always integer and value is always string, fixed.

Thank you

@ondrejmirtes ondrejmirtes merged commit 857d958 into phpstan:master Jan 25, 2021
Copy link
Member

Thank you!

faizanakram99 reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /