-
Notifications
You must be signed in to change notification settings - Fork 534
Narrow l/r/trim() arg on comparison to '' #4340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@staabm
staabm
force-pushed
the
trim
branch
from
September 17, 2025 16:03
795be2d to
59a67bf
Compare
ondrejmirtes
ondrejmirtes
requested changes
Sep 17, 2025
src/Analyser/TypeSpecifier.php
Outdated
) {
$argType = $scope->getType($exprNode->getArgs()[0]->value);
if ($argType->isString()->yes()) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that if you omit if ($argType->isString()->yes()) { and do new IntersectionType([new StringType(), new AccessoryNonEmptyStringType()]), we could also narrow mixed to non-empty-string.
@staabm
staabm
force-pushed
the
trim
branch
2 times, most recently
from
September 18, 2025 05:00
b05b54b to
02f5b9f
Compare
@staabm
staabm
force-pushed
the
trim
branch
from
September 18, 2025 10:02
02f5b9f to
b35db46
Compare
@ondrejmirtes
ondrejmirtes
merged commit Sep 18, 2025
0626464
into
phpstan:2.1.x
455 of 457 checks passed
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#12973