-
Notifications
You must be signed in to change notification settings - Fork 533
fix: checking optional properties in object shapes #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@calebdw
calebdw
force-pushed
the
calebdw/push-mszlmotvuumk
branch
2 times, most recently
from
September 13, 2025 01:44
0c408b3 to
bae03bd
Compare
don't get confused by the CI results.. we currently investigate spurious CI errors
ondrejmirtes
ondrejmirtes
requested changes
Sep 13, 2025
@calebdw
calebdw
force-pushed
the
calebdw/push-mszlmotvuumk
branch
from
September 13, 2025 12:34
bae03bd to
d28fb04
Compare
@calebdw
calebdw
force-pushed
the
calebdw/push-mszlmotvuumk
branch
from
September 13, 2025 12:35
d28fb04 to
692b5be
Compare
@ondrejmirtes
ondrejmirtes
merged commit Sep 15, 2025
330ca96
into
phpstan:2.1.x
443 of 456 checks passed
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Hello!
Closes phpstan/phpstan#13511
By the time the
getProperty()method is called, the$hasPropertyhas already been narrowed tomaybeor it's been determined to be optional and overridden toyes. We should simply continue instead of returningnoThanks!