-
Notifications
You must be signed in to change notification settings - Fork 533
Issue-Bot: Emit GitHub Action annotation when issues are affected #4326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49638aa to
c442163
Compare
c442163 to
feb5c69
Compare
@ondrejmirtes @VincentLanglet any opinion on this? is it acceptable?
if so, I would cleanup the PR and we can give it a try.
if it doesn't work we can remove the annotation just by removing the commit.. so it does not cost much to test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: remove this debug line, which atm enforce rendering of the github action annotation message
Personally I like it
I like it too!
The reason why it's not safe to post a comment is because the only event that has access to secrets is pull_request_target. And you can't check out the repository if you want to be safe. There's a lot of attacks possible if you do that. There's a big warning here: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target
This pull request has been marked as ready for review.
ok cool - lets give it a try then
f6b6762
into
phpstan:2.1.x
Awesome, thank you!
Uh oh!
There was an error while loading. Please reload this page.
with this PR we get a issue-bot 'pull request annotation' in the 'files changed' tab, which looks like:
grafikthis annotation is only visible when issue bot finds affected issues, otherwise no annotation is showing up.
intentionally I used a message type "notice" to get a gentle hint which distracts as less as possible.
Goal: make it more obvious when issue bot has helpful results. before this PR we sometimes missed to check the issue bot results as they are hidden deep in the github.com UI
triggered by a discussion in #4168 (comment)