Fix setting known offset #4270

Original file line number	Diff line number	Diff line change
Expand Up		@@ -750,6 +750,13 @@ public function getType(Expr $node): Type
		return $this->getType($node->getVar())->unsetOffset($this->getType($node->getDim()));
		}
		if ($node instanceof SetOffsetValueTypeExpr) {
	$var = $node->getVar() instanceof OriginalPropertyTypeExpr ? $node->getVar()->getPropertyFetch() : $node->getVar();
Copy link Contributor Author @SplotyCode SplotyCode Aug 30, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. This feels wrong. I don't really get the reason we generally wrap with OriginalPropertyTypeExpr
	if ($node->getDim() !== null && $this->hasExpressionType(new Expr\ArrayDimFetch($var, $node->getDim()))->yes()) {
	return $this->getType($node->getVar())->setExistingOffsetValueType(
	$this->getType($node->getDim()),
	$this->getType($node->getValue()),
	);
	}
		return $this->getType($node->getVar())->setOffsetValueType(
		$node->getDim() !== null ? $this->getType($node->getDim()) : null,
		$this->getType($node->getValue()),
Expand Down

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -59,3 +59,20 @@ public function foo(): void
		$this->collection2[] = 2;
		}
		}

	class TestList
	{

	/**
	* @var list<int>
	*/
	public array $list = [];

	public function setKnownOffset(int $offset): void
	{
	if (isset($this->list[$offset])) {
	$this->list[$offset] = 123;
	}
	}

	}

Navigation Menu