-
Notifications
You must be signed in to change notification settings - Fork 533
do not skip Generator for MissingTypehintCheck #4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+53
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Flyingmana
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
2 times, most recently
from
August 11, 2025 19:14
ebcdd50 to
1dc38d3
Compare
Explained the wanted changes here phpstan/phpstan#7498 (comment)
@Flyingmana
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
from
September 1, 2025 21:04
1dc38d3 to
24bbb81
Compare
I would love to this moving forward. Are you still interested in your PR @Flyingmana ?
I think you just need to
- Rebase/Fix conflicts
- Describe the iterable type in some stubs/tests
Yes, might have time for it later today, but latest next weekend
# Conflicts: # conf/bleedingEdge.neon # conf/config.neon # conf/parametersSchema.neon
@Flyingmana
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
3 times, most recently
from
September 14, 2025 21:38
e47243b to
ac69196
Compare
@Flyingmana
Flyingmana
force-pushed
the
patch-generator_type_missing
branch
from
September 14, 2025 22:13
ac69196 to
e262f13
Compare
I think now all is fixed which belongs to this repository, the rest is separate repositories
This pull request has been marked as ready for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
references #7498
only a draft for now, I want to see which test are all failing and for what reasons.