-
Notifications
You must be signed in to change notification settings - Fork 65
[cs] update coding standard to allow PHP 8 and Slevomat CS 6.4 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where this settings moved, as $usefulAnnotations is not there anymore, but coding standard is passing even without them.
1987d37 to
cc8d8fc
Compare
Ready to merge ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced for all the rules by setting php_version to phpcs.xml config value:
https://github.com/slevomat/coding-standard/blob/614af5a6538aa7c96c45521522b329f770105cab/SlevomatCodingStandard/Sniffs/TypeHints/ParameterTypeHintSniff.php#L92
Done in this file above:
image
35a4dcd to
42d4318
Compare
Thank you!
Uh oh!
There was an error while loading. Please reload this page.
See consistence/coding-standard#65