-
Notifications
You must be signed in to change notification settings - Fork 65
Support for @pure-unless-callable-is-impure
#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging some people in the community about an opinion first, stay tuned :)
3 tasks
Decided to go for it. Other suggestions similar to how Hack handles things are more general, but very complicated to do right now.
@ondrejmirtes
ondrejmirtes
merged commit Sep 26, 2024
6ca22b1
into
phpstan:1.23.x
56 of 57 checks passed
Thank you!
hrach
commented
Sep 26, 2024
What a missed opportunity to name it @pure-iff-callable-is-pure
iff is something math nerds use 😂
hrach
commented
Sep 26, 2024
Maybe an alias? 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for phpstan/phpstan#11100