Add ObjectShapeNode to support @var object{foo: string} $foo #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

samsonasik wants to merge 1 commit into phpstan:1.7.x from samsonasik:add-object-shape

Closed

Add ObjectShapeNode to support @var object{foo: string} $foo #145

samsonasik wants to merge 1 commit into phpstan:1.7.x from samsonasik:add-object-shape

Conversation

samsonasik

Copy link

@samsonasik samsonasik commented Aug 23, 2022

The issue originally on :

RemoveNonExistingVarAnnotationRector removes useful comments rectorphp/rector#7393

which has failing test at:

Test for 7393 rectorphp/rector-src#2797

which the VarTagValueNode got empty variable name and the variable goes to description:

PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode #17240
 type: PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode #17247
 | name: 'object'
 | attributes: array (2)
 | | 'parent' => PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode #17470 see below
 | | 'orig_node' => PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode #17249
 | | | name: 'object'
 | | | attributes: array (1)
 | | | | 'parent' => PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode #17470 see below
 variableName: ''
 description: '{foo: string} $foo'