Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Require whitespace before description with limited start tokens #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:1.5.x from rvanvelzen:description-ws
Jun 8, 2022

Conversation

Copy link
Contributor

@rvanvelzen rvanvelzen commented Jun 8, 2022

Fixes #125

@rvanvelzen rvanvelzen marked this pull request as ready for review June 8, 2022 13:18
Copy link
Member

I really like this! I'm gonna check the integration tests in PHPStan before tagging a release here because there might be some real-world impact.

@ondrejmirtes ondrejmirtes merged commit d579798 into phpstan:1.5.x Jun 8, 2022
Copy link
Member

Thank you!

new PhpDocTagNode(
'@return',
new InvalidTagValueNode(
'\Closure(...int, string): string',
Copy link
Contributor

@mvorisek mvorisek Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for throwing at least

as all other types in \Closure phpdoc does not require a variable name, can support for unnamed variadic phpdoc be added?

Copy link
Contributor Author

@rvanvelzen rvanvelzen Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already supported, but the type always has to come first.

Copy link
Contributor

@mvorisek mvorisek Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know, thank you ❤️

@rvanvelzen rvanvelzen deleted the description-ws branch June 8, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnamed vargs type in callable/Closure phpdoc is silently ignored

AltStyle によって変換されたページ (->オリジナル) /