-
-
Notifications
You must be signed in to change notification settings - Fork 109
Ignore E2E test data for Git export #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore E2E test data for Git export #622
Conversation
- Fixes phpmyadmin#621 Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be too risky for new tests to have missing data
can you check in setUp() if the folder exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There some test classes that have more than e2e tests, so skipping in setUp() will also skip valid tests that do not depend on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best option is to refactor the tests, but I don't know how much refactoring is needed. I already attempted changing those tests (#598), but I'm yet to find a good solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, can you turn the phpunit to error when there is skipped tests on the CI?
I think that will be a good safety measure
Or use incomplete instead of skipped
Uh oh!
There was an error while loading. Please reload this page.
We can work on
masterbranch a way of extracting these tests and run them separately.