-
Notifications
You must be signed in to change notification settings - Fork 464
Sub-URI support based on config option PMA_SUB_URI_BASE #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @fishermans
I appreciate the effort for the feature, I can not agree with using the PMA prefix since this is not a phpMyAdmin setting but some virtual config trick only available in docker :)
Could you find another name?
@J0WI what do you think about this PR?
Will it be accepted in official Docker images?
Hi @fishermans I appreciate the effort for the feature, I can not agree with using the PMA prefix since this is not a phpMyAdmin setting but some virtual config trick only available in docker :) Could you find another name?
@J0WI what do you think about this PR? Will it be accepted in official Docker images?
Hi @williamdes,
It is of course possible to change this name as you like. Please just suggest a name and I will change the PR.
I thought that the variable should be similar to the other variables, so that it can be distinguished from your own ones. But I personally don't care at all what it should be called. The main thing is that you can start a PMA in Docker under a sub-URI in no time without having to create your own images.
BR
Maybe it is also possible to support sub-URI in general in PMA, for Docker and for native installations. If you do not have a wildcard certificate for your domain and working at a company where you have to ask other people to help you... sub-URI is very welcome.
Something like https://www.php.net/manual/en/function.symlink.php should also work. But I am not an export in PHP as you know what I mean. The ENTRYPOINT "hack" was simple to implement and is easy to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this can not be called PMA_SUB_URI_BASE starting with PMA_ means it is a phpMyAdmin config option
Maybe URL_BASE ?
@dhanyn10singapay
dhanyn10singapay
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create symlink if link target does not already exit.
Uh oh!
There was an error while loading. Please reload this page.
To support docker container behind a reverse proxy I added a new optional config option to simply running PMA under a sub-URI based on approach posted on Stackoverflow: https://stackoverflow.com/questions/42035947/how-to-change-the-access-url-of-official-phpmyadmin-docker-image-to-http-local/68643939#68643939
It simply creates a symlink inside the www folder.