-
Notifications
You must be signed in to change notification settings - Fork 25
Added process of booleans #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added process of booleans #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the changes but I have a few remarks:
- In processValue declare argument type as string
- In load function , is not necessary return the values that have been loaded into ENV
Thanks
Perfect, I think all changes have been made
Ok for me , thanks
You are forget to remove unit test about returns values :
/**
* @runInSeparateProcess
*/
public function testLoadReturnsValues()
{
$loaded = (new DotEnv($this->env('.env.return')))->load();
$this->assertEquals('returned', $loaded['VALUE']);
$this->assertEquals('returned', $_ENV['VALUE']);
}
test failed
If the .env file has a boolean value it will be parsed into the correct type:
.env file:
VARIABLE=trueBefore:
$_ENV['VARIABLE] = 'true';Now:
$_ENV['VARIABLE] = true;DotEnv::PROCESS_BOOLEANS.@runInSeparateProcesshas been added to the test to restart$_ENVvariables