-
Notifications
You must be signed in to change notification settings - Fork 8k
Make pestr[n]dup infallible #9295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternatively we could make zend_strndup
infallible itself, which would probably not be a bad idea.
Alternatively we could make
zend_strndup
infallible itself, which would probably not be a bad idea.
I tend to agree.
Alternatively we could make
zend_strndup
infallible itself, which would probably not be a bad idea.I tend to agree.
seconded.
Fixes phpGH-9128 Closes phpGH-9295
@iluuu1994
iluuu1994
force-pushed
the
infallible-pestrdup
branch
from
August 12, 2022 09:25
235e789
to
4516319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-9128