-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add tests to check ZPP handles intersection types for internal functions #9100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ext/zend_test/test_arginfo.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to add support for intersection types in the arginfo? Right now, the return type seems a bit inaccurate (?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually check the output of the arginfo >_> so yeah that would need fixing.
Not too sure how to add support, but I wanted to add a test to make sure stuff "works" which it seems although it's inacurate. Let me get back to this, and thanks for catching this :)
06030cf to
ca8e332
Compare
(削除) I'm not sure if I need to do anything specific in the arg info to support intersection types actually. As I can't seem to find usages which use the type directly (削除ここまで)
Need to amend zend_verify_internal_arg_types()
Just to be sure, Arg Info doesn't actually support multiple class unions either? Or does it?
Just to be sure, Arg Info doesn't actually support multiple class unions either? Or does it?
Yeah, it is missing unfortunately :S I may be able to work on it though, if you do not want to
No description provided.