Fix #8952: std streams can not be deliberately closed #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

arnaud-lb merged 2 commits into php:PHP-8.1 from arnaud-lb:issue-8952

Jul 9, 2022

Merged

Fix #8952: std streams can not be deliberately closed #8953

arnaud-lb merged 2 commits into php:PHP-8.1 from arnaud-lb:issue-8952

Jul 9, 2022

Conversation

arnaud-lb

Copy link

Member

@arnaud-lb arnaud-lb commented Jul 8, 2022

#8827 has been fixed in 8.0, but the fix was incomplete for 8.1 (see #8952).

@arnaud-lb


 Fix  phpGH-8952 : std streams can not be deliberately closed

de84d48

@github-actions github-actions bot added the SAPI: cli label

Jul 8, 2022

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.1

July 8, 2022 12:39

@arnaud-lb


 rebuild

47d83d7

@arnaud-lb arnaud-lb marked this pull request as ready for review

July 8, 2022 13:42

@arnaud-lb arnaud-lb requested a review from cmb69

July 8, 2022 13:42

@arnaud-lb

Copy link

Member Author

arnaud-lb commented Jul 8, 2022

The FreeBSD build failure is unrelated

@arnaud-lb arnaud-lb added the Waiting on Review label

Jul 8, 2022

cmb69

cmb69 approved these changes

Jul 8, 2022

View reviewed changes

Copy link

Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Looks good to me. Maybe @fds242 and @moonlitbugs want to double-check.

@bukka

Copy link

Member

bukka commented Jul 9, 2022

LGTM too, please commit it. I will modify my changes in #8833 to be correctly applied.

@arnaud-lb arnaud-lb merged commit 2dbde18 into php:PHP-8.1

Jul 9, 2022

arnaud-lb added a commit that referenced this pull request

Jul 9, 2022

@arnaud-lb


 Merge branch 'PHP-8.1'

da1cbd2

* PHP-8.1:
 [ci skip] NEWS
 Fix GH-8952: std streams can not be deliberately closed (#8953)
 intl extension, build fix for icu >= 69.x release. ubrk/ucnv_safeClone had been deprecated in favor of ubrk/ucnv_clone which does not use user provided stacks but remain thread safe.