-
Notifications
You must be signed in to change notification settings - Fork 8k
Improved responses to different requests on static resources in built-in web server #8215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will fix those failing tests and get back with an improved version.
84c9371 to
ba5daea
Compare
Hi, @vedranmiletic! This PR is waiting on some feedback from you before we can merge it.
As @cmb69 indicated:
The origin server MUST generate an Allow header field in a 405 response containing a list of the target resource's currently supported methods.
— https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.5
Does the CLI server already do this?
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken.
This might be worth to leave for a bit longer open
Sorry for the delay. I will do the requested changes soon.
ba5daea to
1e9badb
Compare
Great CI results. Test incoming.
Co-authored-by: Marin Martuslović <marin.martuslovic@student.uniri.hr>
...resource Co-authored-by: Marin Martuslović <marin.martuslovic@student.uniri.hr>
1e9badb to
b710d16
Compare
Just FYI I messaged internals if this could be added before the first 8.2 RC.
it could went in as bugfix to support 405 status
@andypost I think it's probably more for master even though it's probably somewhere between feature and bug.
We use PHP's built-in web server for teaching HTTP requests and responses. These two patches handle some edge cases of interest to us.