MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN #20033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

wmamrak wants to merge 2 commits into php:PHP-8.3

from wmamrak:fix-win32-warning

Open

MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN #20033

wmamrak wants to merge 2 commits into php:PHP-8.3 from wmamrak:fix-win32-warning

+9 −3

Conversation

wmamrak

Copy link

@wmamrak wmamrak commented Oct 1, 2025

Build systems often pass /DWIN32_LEAN_AND_MEAN to the compiler. Several headers also define this macro unconditionally, which causes C4005 (macro redefinition) warnings in the build log.

This commit wraps the definitions in #ifndef guards to resolve the warnings.

@wmamrak


 MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN

c5a62dd

Build systems often pass /DWIN32_LEAN_AND_MEAN to the compiler. Several headers also define this macro unconditionally, which causes C4005 (macro redefinition) warnings in the build log.
This commit wraps the definitions in #ifndef guards to resolve the warnings.