-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-20002: build on BSD with MSAN #20032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
iluuu1994
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise, thanks!
@outtersg
outtersg
force-pushed
the
gh20002
branch
from
October 1, 2025 15:01
a5ccd01 to
f88b4d7
Compare
The #if to have instrumented versions of strlcpy and strlcat was too inclusive, and defined them even on *BSD that indeed have those already defined, resulting in "duplicate symbol" at linking.
@outtersg
outtersg
force-pushed
the
gh20002
branch
from
October 1, 2025 16:17
f88b4d7 to
36a5f83
Compare
Great, thank you @outtersg!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
See #20002.
The
#ifto have instrumented versions of strlcpy and strlcat was too inclusive, and defined them even on *BSD that indeed have those already defined, resulting in "duplicate symbol" at linking.We use a really simple heuristic here (OSes that are used to have instrumented
strlcpyandstrlcatalready defined in their msan library do not redefine them).