-
Notifications
You must be signed in to change notification settings - Fork 8k
Use interned strings for class properties in stub-generated files #20015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+373
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
Category: Build System
Category: Engine
Extension: intl
Extension: bcmath
Extension: curl
Extension: date
Extension: dom
Extension: libxml
Extension: mysqli
Extension: pdo (core)
Extension: snmp
Extension: soap
Extension: spl
Extension: standard
Extension: tidy
Extension: tokenizer
Extension: xmlreader
Extension: xsl
Extension: zend_test
Extension: zip
Extension: random
ABI break
Extension: uri
labels
Sep 30, 2025
@nielsdos
nielsdos
requested review from
kocsismate,
bukka,
Girgias,
TimWolla and
zeriyoshi
as code owners
September 30, 2025 16:03
@nielsdos
nielsdos
requested review from
SakiTakamachi,
kamil-tekiela,
devnexen,
derickr and
adoy
as code owners
September 30, 2025 16:03
Girgias
Girgias
approved these changes
Sep 30, 2025
devnexen
devnexen
approved these changes
Sep 30, 2025
$propertyName,
$this->phpVersionIdMinimumCompatibility
$this->phpVersionIdMinimumCompatibility,
true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could the parameter be made required so that the same omission becomes less likely next time?
kocsismate
kocsismate
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch, thanks for finding this!
zeriyoshi
zeriyoshi
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.