-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-19999: GC refcount assertion failure when destructor modifies variable during concat #20004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alexandre-daubois
alexandre-daubois
changed the base branch from
master
to
PHP-8.3
September 30, 2025 08:59
I'm not sure it worth a NEWS entry?
@alexandre-daubois
alexandre-daubois
force-pushed
the
gc-dtor-concat
branch
from
September 30, 2025 09:08
49b99b7 to
fade10b
Compare
...es variable during concat
@alexandre-daubois
alexandre-daubois
force-pushed
the
gc-dtor-concat
branch
from
September 30, 2025 09:32
fade10b to
396ac4d
Compare
@alexandre-daubois Any bugfix to a release branch needs a NEWS entry.
...es variable during concat
Preventing the crash is relatively simple, but it causes repeated leaks. I've tried quite a few things, but in the end, it's a game of cat and mouse and doesn't really solve the underlying problem.
Let's close for the reasons exposed here: #19929 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19999