-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix GH-16319: protect fiber backtrace with null filename from crashing #19973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f15b50c to
4b72343
Compare
Not sure how to skip the test on CircleCI, where it seems that --enable-zend-test isn't provided? Help welcome 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
NEWS
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this NEWS entry, zend_test is not a user-targeted extension.
Not sure how to skip the test on CircleCI, where it seems that --enable-zend-test isn't provided? Help welcome 🙂
I don't think it's because the extension is not available, that is skipped with --EXTENSIONS--. It might be because of --repeat 2, or JIT.
Skipping when using JIT in CircleCI seems to do the trick
I'm not sure if this is expected though? Other observer tests are not skipped with JIT.
cc8c020 to
3a9be7e
Compare
Okay, I can see some where JIT is explicitly disabled like you do, e.g. (ext/zend_test/tests/observer_opline_01.phpt). So this looks ok to me now. 👍
Oh indeed! I was about to ping Arnaud. Thanks for pointing an existing case!
a64c738 to
e857638
Compare
e857638 to
75f041b
Compare
9fc14a9
into
php:PHP-8.3
Uh oh!
There was an error while loading. Please reload this page.
Fix #16319
Used
[no active file]as it's already used at many places.