-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Zend: Implement __unserialize() for Exception/Error #19826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+219
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Girgias
Girgias
force-pushed
the
exceptions-unserialize-magicmethod
branch
from
September 13, 2025 17:18
ac4e09d to
125c1ff
Compare
@Girgias
Girgias
force-pushed
the
exceptions-unserialize-magicmethod
branch
from
September 14, 2025 12:10
125c1ff to
c9186f7
Compare
I am closing this as the reason for __wakeup() to exist is to verify the type of the message and code properties. As those would, hopefully, use actual property types in PHP 9 we can then just remove the __wakeup() method as it will then serve no purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the DOM classes the only classes that only have
__sleep()magic methods, and__wakeup()methods without a corresponding__unserialize()magic method, as it is needed to allow serialization of child classes.