-
Notifications
You must be signed in to change notification settings - Fork 7.9k
core: set zend_pass_function as default constructor #19797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
+255
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Girgias
Girgias
force-pushed
the
default-pass-ctor
branch
3 times, most recently
from
September 11, 2025 08:39
bf13ae2 to
e89c0d3
Compare
@Girgias
Girgias
force-pushed
the
default-pass-ctor
branch
from
September 11, 2025 10:10
e89c0d3 to
4490fee
Compare
@Girgias
Girgias
force-pushed
the
default-pass-ctor
branch
2 times, most recently
from
September 11, 2025 12:29
cc51c73 to
5508388
Compare
This is to make the semantics of when a class cannot be instiantiated obvious rather than needed to remember to call the get_constructor() handler.
@Girgias
Girgias
force-pushed
the
default-pass-ctor
branch
from
September 11, 2025 13:26
5508388 to
dfbe9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make the semantics of when a class cannot be instantiated obvious, rather than needed to remember to call the get_constructor() handler and discard the exception.
Possible solution to #17796
Very much W.I.P.