-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add isWeekend() and isWeekday() methods to DateTime classes #19734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xentixar
wants to merge
3
commits into
php:master
from
xentixar:add-weekend-and-weekday-methods-to-datetime-class
Open
Add isWeekend() and isWeekday() methods to DateTime classes #19734
xentixar
wants to merge
3
commits into
php:master
from
xentixar:add-weekend-and-weekday-methods-to-datetime-class
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xentixar
xentixar
requested review from
kocsismate and
derickr
as code owners
September 6, 2025 09:22
devnexen
devnexen
reviewed
Sep 6, 2025
Why do you consider the weekend to be Saturday and Sunday? Why not other days? How is this determined? see https://en.wikipedia.org/wiki/Workweek_and_weekend#History
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods to DateTime and DateTimeImmutable classes:
The methods are also declared in DateTimeInterface, ensuring they're available across all implementing classes.
Implementation includes:
These methods provide a convenient way to check if a date is a weekend or weekday without manually checking the day of week.