-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix OSS-Fuzz #442954659: zero-size box in HEIF file causes infinite loop #19724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nielsdos
nielsdos
force-pushed
the
heic-hang
branch
from
September 5, 2025 17:14
be85cfd to
ebdb558
Compare
@nielsdos
nielsdos
force-pushed
the
heic-hang
branch
from
September 5, 2025 17:19
ebdb558 to
7837ca8
Compare
If the box size is 0, the loop can't progress.
@nielsdos
nielsdos
force-pushed
the
heic-hang
branch
from
September 7, 2025 10:51
ad9ea5e to
cb61953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
If the box size is 0, the loop can't progress, resulting in a DoS.
Fixes https://issues.oss-fuzz.com/issues/442954659
I think there might be more subtle issues with this code, like
offsetis controllable by a user sooffset + 16can overflow which is UB... But that's for a separate PR.